From 8ccc27127bd5abcba05f30f8a72fc37025b588ac Mon Sep 17 00:00:00 2001 From: Aarni Koskela Date: Sun, 30 Apr 2023 22:08:52 +0300 Subject: Fix a whole bunch of implicit globals --- javascript/notification.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'javascript/notification.js') diff --git a/javascript/notification.js b/javascript/notification.js index 8ddd4c5d..a40de7c3 100644 --- a/javascript/notification.js +++ b/javascript/notification.js @@ -2,7 +2,7 @@ let lastHeadImg = null; -notificationButton = null +let notificationButton = null; onUiUpdate(function(){ if(notificationButton == null){ -- cgit v1.2.3 From f6a40a2ffacaba63915f11c47e77e84a06ed073c Mon Sep 17 00:00:00 2001 From: Aarni Koskela Date: Sun, 30 Apr 2023 22:12:24 +0300 Subject: Fix unused variables --- javascript/notification.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'javascript/notification.js') diff --git a/javascript/notification.js b/javascript/notification.js index a40de7c3..32913bac 100644 --- a/javascript/notification.js +++ b/javascript/notification.js @@ -9,7 +9,7 @@ onUiUpdate(function(){ notificationButton = gradioApp().getElementById('request_notifications') if(notificationButton != null){ - notificationButton.addEventListener('click', function (evt) { + notificationButton.addEventListener('click', () => { Notification.requestPermission(); },true); } -- cgit v1.2.3 From b7269f781c0c673c09beff6ec5fb33ea6b4779a6 Mon Sep 17 00:00:00 2001 From: Aarni Koskela Date: Sun, 30 Apr 2023 22:14:51 +0300 Subject: Mark Notification.requestPermission's retval as purposely ignored --- javascript/notification.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'javascript/notification.js') diff --git a/javascript/notification.js b/javascript/notification.js index 32913bac..83fce1f8 100644 --- a/javascript/notification.js +++ b/javascript/notification.js @@ -10,7 +10,7 @@ onUiUpdate(function(){ if(notificationButton != null){ notificationButton.addEventListener('click', () => { - Notification.requestPermission(); + void Notification.requestPermission(); },true); } } -- cgit v1.2.3