From 2dce69c4dea0bcb9e98c2965e6ac6b25402fcae9 Mon Sep 17 00:00:00 2001 From: Martin Pärtel Date: Sun, 8 Jun 2025 14:38:18 +0300 Subject: -onoattrcache with fuse-t by default. Maybe it gets rid of test flakiness. --- src/bindfs.1 | 2 -- src/bindfs.c | 4 ++++ tests/test_bindfs.rb | 4 ++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/bindfs.1 b/src/bindfs.1 index ceda806..e89ba2d 100644 --- a/src/bindfs.1 +++ b/src/bindfs.1 @@ -551,8 +551,6 @@ MacFuse caches file contents by default. This means that changes in source files are not always immediately visible under the mount point. \fB\-o nolocalcaches\fP can be used to disable the cache. -With fuse-t, \fB\-o noattrcache\fP is recommended. - When using \fB\-\-mirror[-only] @somegroup\fP, bindfs won't see changes to the group's member list. Sending bindfs a \fBSIGUSR1\fP signal will make it reread the user database. diff --git a/src/bindfs.c b/src/bindfs.c index aab2df5..e0e4c1c 100644 --- a/src/bindfs.c +++ b/src/bindfs.c @@ -2878,6 +2878,10 @@ int main(int argc, char *argv[]) fuse_opt_add_arg(&args, "-ouse_ino"); #endif +#ifdef HAVE_FUSE_T + fuse_opt_add_arg(&args, "-onoattrcache"); +#endif + /* Show the source dir in the first field on /etc/mtab, to be consistent with "real" filesystems. diff --git a/tests/test_bindfs.rb b/tests/test_bindfs.rb index 5f9fc18..c068b28 100755 --- a/tests/test_bindfs.rb +++ b/tests/test_bindfs.rb @@ -755,8 +755,8 @@ testenv("--resolve-symlinks", :title => "resolving broken symlinks") do end # Issue #28 reproduction attempt. -# Flaky on fuse-t without noattrcache (2025-06-08) -testenv(if $fuse_t then "-o noattrcache" else "" end, :title => "many files in a directory") do +# Observation (2025-06-08): Flaky on fuse-t without noattrcache. Enabled by default by bindfs since. +testenv("", :title => "many files in a directory") do mkdir('src/dir') expected_entries = ['.', '..'] 10000.times do |i| -- cgit v1.2.3