From 7d4a947e1bfef5611578d440a3106500c1704cb7 Mon Sep 17 00:00:00 2001 From: Martin Pärtel Date: Sat, 15 Oct 2016 01:54:44 +0100 Subject: Always skip valgrind for ioctl tests due to false negatives. --- tests/test_bindfs.rb | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/test_bindfs.rb b/tests/test_bindfs.rb index e355e2a..48611b2 100755 --- a/tests/test_bindfs.rb +++ b/tests/test_bindfs.rb @@ -658,7 +658,9 @@ testenv("--disable-lock-forwarding", :title => "no lock forwarding") do end # Issue #37 -root_testenv("--enable-ioctl", :title => "append-only ioctl") do +# Valgrind disabled for ioctl tests since it seems to give a false negative +# about a null parameter to ioctl. +root_testenv("--enable-ioctl", :title => "append-only ioctl", :valgrind => false) do touch('mnt/file') system('chattr +a mnt/file') raise 'chattr +a failed' unless $?.success? @@ -673,7 +675,7 @@ root_testenv("--enable-ioctl", :title => "append-only ioctl") do end end -root_testenv("", :title => "ioctl not enabled by default") do +root_testenv("", :title => "ioctl not enabled by default", :valgrind => false) do touch('mnt/file') assert { `chattr +a mnt/file 2>&1`; !$?.success? } end -- cgit v1.2.3