diff options
| author | yangyun <yangyun50@huawei.com> | 2024-02-23 11:06:08 +0800 |
|---|---|---|
| committer | yangyun <yangyun50@huawei.com> | 2024-02-23 15:01:29 +0800 |
| commit | fce970c313bf25ba9ae5b6a335e3293736df3d48 (patch) | |
| tree | e38ec6d010af8c954e7c954c5fcf0e2ff6470800 /example/passthrough.c | |
| parent | 402c8fff588120a7cf5922822904ce45f30612a8 (diff) | |
| download | libfuse-fce970c313bf25ba9ae5b6a335e3293736df3d48.tar.gz | |
passthrough_example: make parallel_direct_writes more clearly
Move the parallel_direct_writes enable action to the init function in high level API,
it is more recommended just like commit 8ee553dac. Besides, add some comments to show
that the feature parallel_direct_writes is depend on the feature direct_io (refer to
kernel side patch series to consolidate direct IO, link: https://lwn.net/ml/linux-fsdevel/
20230918150313.3845114-1-bschubert@ddn.com for the reason).
Diffstat (limited to 'example/passthrough.c')
| -rw-r--r-- | example/passthrough.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/example/passthrough.c b/example/passthrough.c index dd385c5..5a0d6d7 100644 --- a/example/passthrough.c +++ b/example/passthrough.c @@ -59,6 +59,13 @@ static void *xmp_init(struct fuse_conn_info *conn, (void) conn; cfg->use_ino = 1; + /* parallel_direct_writes feature depends on direct_io features. + To make parallel_direct_writes valid, need either set cfg->direct_io + in current function (recommended in high level API) or set fi->direct_io + in xmp_create() or xmp_open(). */ + // cfg->direct_io = 1; + cfg->parallel_direct_writes = 1; + /* Pick up changes from lower filesystem right away. This is also necessary for better hardlink support. When the kernel calls the unlink() handler, it does not know the inode of @@ -285,7 +292,6 @@ static int xmp_create(const char *path, mode_t mode, return -errno; fi->fh = res; - fi->parallel_direct_writes = 1; return 0; } @@ -298,7 +304,6 @@ static int xmp_open(const char *path, struct fuse_file_info *fi) return -errno; fi->fh = res; - fi->parallel_direct_writes = 1; return 0; } |